Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Task 상태 수정 api (드래그앤드롭 부분 우선 구현) #192

Merged
merged 8 commits into from
Jul 18, 2024
Merged

[FEAT] Task 상태 수정 api (드래그앤드롭 부분 우선 구현) #192

merged 8 commits into from
Jul 18, 2024

Conversation

Kjiw0n
Copy link
Contributor

@Kjiw0n Kjiw0n commented Jul 18, 2024 •
edited
Loading

작업 내용 🧑‍💻

  • Task 수정 api를 연결하였습니다.
  • stagingArea <-> targetArea 드래그앤드롭 시 수정(Patch) api 호출 및 useMutation을 통한 Task 리스트 자동 업데이트 기능입니다.

알게된 점 🚀

기록하며 개발하기!

  • useQuery에 placeholderData 사용 시 한번 불러올 때만 깜빡임이 심하고, 그 이후에는 기존에 캐시된 값으로 깜빡임을 최소화할 수 있다는 것을 알았습니다.

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 드래그앤드롭 시 나타나는 찰나의(아마 Fetching동안) 다시 제자리로 돌아가는 부분 수정이 필요합니다. 지속적으로 개선중에 있지만 같이 고민해주시면 감사하겠습니다..!

관련 이슈

close #174

스크린샷 (선택)

Jul-18-2024 14-55-06

@Kjiw0n Kjiw0n self-assigned this Jul 18, 2024
@Kjiw0n Kjiw0n changed the title [FEAT] Task 상태 수정 api [FEAT] Task 상태 수정 api (드래그앤드롭 부분 우선 구현) Jul 18, 2024
seong-hui
seong-hui approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드로그 앤 드랍에 api를 붙이기 위해서 많은 로직을 상위 컴포넌트로 가져오는 작업이 번거로우셨을텐데 props interface를 따로 정리해주셔서 더욱 좋은 것 같습니다! 너무너무 고생하셨습니다!! 👍

src/pages/Today.tsx Outdated

const [removed] = sourceClone.splice(source.index, 1);
const { mutate } = useMutation({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 Mutation 코드는 api 내에 query 파일에 분리하는 건 어떨까요? 나중에 해당 쿼리를 수정할 때 더 용이할 것 같습니다!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 분리하였습니다!!

@Kjiw0n Kjiw0n force-pushed the feat/#174-status-edit-api branch from 5adcf78 to ea0ff13 Compare July 18, 2024 07:24
jeeminyi
jeeminyi approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으앙 ,,~ 고생 많으셨어요,, 특히 상태 업데이트 부분, , 고생 정말 많으셨겠네요,, 수고하셨습니다!!!

src/apis/tasks/updateTaskStatus/UpdateTaskStatusType.ts
Comment on lines +2 to +4
taskId: number;
targetDate?: string | null;
status?: string | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옵셔널로 해주고 또 null까지 처리해주신 이유가 뭔가용?-? (진짜 몰라서 그럼,,)

@Kjiw0n Kjiw0n merged commit fa15fdd into develop Jul 18, 2024
2 checks passed
@Kjiw0n Kjiw0n deleted the feat/#174-status-edit-api branch July 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeminyi jeeminyi jeeminyi approved these changes

@seong-hui seong-hui seong-hui approved these changes

@wrryu09 wrryu09 Awaiting requested review from wrryu09

Assignees

@Kjiw0n Kjiw0n

Labels
🍀 지원 🔗 api 연결
Projects
@DAWM-FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Task 상태 수정 api 연결
3 participants
@Kjiw0n @seong-hui @jeeminyi